I had this feel week ago but now I'm getting bullied by the seniors on code review section. Feels rough man
"your code is fine, but why does the last line say "let me know if you'd like to refactor"
That’s because the principals bully the seniors and the seniors bully the seniors and the principals also bully the principals
Basically everyone’s insecure about their own shit lol
Experiencing this right now.
seniors: "We have this cool name for a simple implementation of a standard process called GANODNOGEWNOENN"
me: "Hey that's kinda complicated. Why not just keep it simple? There's no need to invent new words for something as simple as that."
I guess I'm lucky to've always had supportive and wholesome principals and seniors.
I bet everyone on this sub has(or should have) felt this way after every single person on the team bashes your PR and now you have your TL breathing on your neck instructing line by line what you were supposed to do
see it as kind of a birth by fire ritual, sometimes it's a terrible bootstrap process, some others you just didn't pay enough attention and others it's just not possible to learn all of the ins & outs of the workflows
don't worry, take notes, learn from your peers and ask a lot, you'll be fine
A good review process is a sign of a healthy team, don't let your ego get hurt, you are working with multiple people on features like this, that's exactly what its designed for.
Think of it like this, a fresh set of eyes sees things you might have overlooked and even the most senior devs have this.
It's part of the process of good software development, better get comfortable with it.
Give it some time and you'll be the one telling them to fuck off and they're wrong.
This was me after adding target = blank to an a href.
Don't worry about code reviews, it's helpful constructive criticism, even I after 8 years of experience still make silly errors and appreciate a lot the other devs that actually go the extra mile of looking at my code and make helpful suggestions.
Also I'll give you some advice, try to ask things around, ask for books to read or sources to study, your code is not perfect, own it, there's always lots of space to grow no matter your experience, so be humble.
And when the bugs are raised, the mirror shatters and lessons starts.
2022 I started as a Jr. Dev
One thing I learned:
Responsibility comes from saying too late no.
So I have the habit to say no even before the question was asked.
Sometimes I shoot myself with this habit, but better than managing a project, underpaid, as a Jr. Dev.
Senior: think of an ETA and triple it
Staff: say you are fully booked until next year and then quadruple the ETA
Principal: providing an ETA requires 6 months research and we will need to hire 5 experienced engineers to execute on it
When the code review gets approved without being sent back
I had this feeling after switching job. I already have 11 YOE..
Back in the day it was easier. My first job out of college was to build a reporting platform for a 5000 people company based on SQL, .Net, SSIS and SSAS. Data came from SAP R3 and there was no other person involved. I had to learn fast and there was no person judging my code. After everything went into production I was sent of to another team to be trained for a team leader role which I took over a couple months later. golden times
As a senior “shit I hope I didn’t completely misunderstand something”
Really need a small but growing fire in the background
Fake. Jr devs dont know how to use reflection
"Looks like prod has gone down"
"pleasedontbemyfaultpleasedontbemyfaultpleasedontbemyfaultpleasedontbemyfault"
It always goes down right after your code goes out.
Prod isn't rolling on the latest commit right? It's by release, right???
In an ideal world…
JFC ain't this the truth. I pushed my first change to a new project. All of the unit tests and integration tests were passing, QA had seen no issues, but right after my change was released we had an outage.
I was panicking at first but it turned out to be a poorly timed Google service outage.